dev/core#1812 Do not allow enabling database logging when using multilingual

[spalmstr]

Overview

Logging is not supported in a multilingual environment, but that is not made clear on the page that enables logging. This deals with issue Missing view when logging set in a non-US English instance. by making it impossible in the future to enable logging in a multilingual environment.

Before

After

Technical Details

We test for if the environment is multilingual, and if it is, change the template message. Also, if someone attempts to enable logging, we throw an error.

Comments

I spent quite some time investigating the possibility of supporting a multilingual environment, but realised it is quite complicated and need lots of testing. This PR clarifies the current position.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks for the PR.

• General standards
  • [r-explain] PASS
    • Just to add some context: There is already a restriction if you enable logging first and then go to enable multilingual - it won't let you. But it will currently let you enable multilingual and then logging, so this PR makes it consistent.
  • [r-user] PASS
  • [r-doc] PASS
    • This note is partly still true: https://docs.civicrm.org/sysadmin/en/latest/setup/logging/#system-requirements. I'm not sure what it would change to though - it would seem out of place in the docs to tell people how to hack it in order to "experiment".
  • [r-run] PASS
    • I see this is consistent with how the trigger warning works, where it still lets you check Yes but then gives an error on save. That could be improved but I'd suggest out of scope here.
• Developer standards
  • [r-tech] Issue
    • Will need to rebase and squash commits.
  • [r-code] Issue
    • The style-checker doesn't run on .tpl files but to be consistent this should all be 2 space indents.
  • [r-maint] N/A
  • [r-test] PASS

[demeritcowboy]

Hi @spalmstr the commits still need squashing. It's a task that involves a lot of yelling and fist-shaking the first few times, but I find this article can get you out of trouble if you get stuck, and then you don't have to deal with the weird "interactive rebase" UI: https://stackoverflow.com/a/6103022/8332458

[demeritcowboy]

Jenkins retest this please (test fail is a known intermittent failure)

[seamuslee001]

just pining @mlutfy but this seem quite sensible to me

[eileenmcnaughton]

Agree we don't need aa test on a wording change