Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1861 fix failure to unset location_type_id when saving uffield #17812

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/core/-/issues/1861

If this is a regression it probably from 2017
2e74ff5#diff-1911d0c1a896701ba9aa044181f5972bR556

Before

When updating a field within a profile 'Primary' does not save NULL to the DB and the prior location type is retained

After

Saves

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 13, 2020

(Standard links)

@civibot civibot bot added the master label Jul 13, 2020
@alifrumin
Copy link
Contributor

I tested this on the jenkins build and it resolves the bug documented on https://lab.civicrm.org/dev/core/-/issues/1861.

THANK YOU EILEEN

@eileenmcnaughton
Copy link
Contributor Author

Unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit a6f78de into civicrm:master Jul 13, 2020
@eileenmcnaughton eileenmcnaughton deleted the uff branch July 13, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants