dev/core#1863 Downgrade checkEnvironment level and skip non-prod checks #17807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -142,7 +142,7 @@ public function checkDebug() { | |||
| ts('Warning: Debug is enabled in <a href="%1">system settings</a>. This should not be enabled on production servers.', | |||
| [1 => CRM_Utils_System::url('civicrm/admin/setting/debug', 'reset=1')]), | |||
| ts('Debug Mode Enabled'), | |||
| \Psr\Log\LogLevel::WARNING, | |||
| CRM_Core_Config::environment() == 'Production' ? \Psr\Log\LogLevel::WARNING : \Psr\Log\LogLevel::INFO, | |||
There was a problem hiding this comment.
You don't get pop ups for info do you?
|
This looks good - I have only given the code a light read but pending a better review we should merge IMHO |
|
@kcristiano do you have time to review this one as well? |
colemanw
added
the
merge ready
|
Thanks @kcristiano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In non-production environments, CiviMail and other Cron-based jobs are disabled, yet the system checks for them still run. There's also a system check that reports non-production environments, and it uses an inappropriately high alert level.
Based on discussion in dev/core#1863
Before
checkEnvironmentblasts its message at\Psr\Log\LogLevel::ALERTAfter
checkEnvironmentlevel downgraded to\Psr\Log\LogLevel::NOTICE