-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#1863 Downgrade checkEnvironment level and skip non-prod checks #17807
Conversation
(Standard links)
|
@@ -142,7 +142,7 @@ public function checkDebug() { | |||
ts('Warning: Debug is enabled in <a href="%1">system settings</a>. This should not be enabled on production servers.', | |||
[1 => CRM_Utils_System::url('civicrm/admin/setting/debug', 'reset=1')]), | |||
ts('Debug Mode Enabled'), | |||
\Psr\Log\LogLevel::WARNING, | |||
CRM_Core_Config::environment() == 'Production' ? \Psr\Log\LogLevel::WARNING : \Psr\Log\LogLevel::INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't get pop ups for info do you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
This looks good - I have only given the code a light read but pending a better review we should merge IMHO |
@kcristiano do you have time to review this one as well? |
Thanks @kcristiano |
Overview
In non-production environments, CiviMail and other Cron-based jobs are disabled, yet the system checks for them still run. There's also a system check that reports non-production environments, and it uses an inappropriately high alert level.
Based on discussion in dev/core#1863
Before
checkEnvironment
blasts its message at\Psr\Log\LogLevel::ALERT
After
checkEnvironment
level downgraded to\Psr\Log\LogLevel::NOTICE