Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Do or do not - there is no try #17795

Merged
merged 1 commit into from
Jul 12, 2020
Merged

[REF] Do or do not - there is no try #17795

merged 1 commit into from
Jul 12, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

I'm either missing something or the try part is unnecessary.

Also add some comments.

@civibot
Copy link

civibot bot commented Jul 12, 2020

(Standard links)

@civibot civibot bot added the master label Jul 12, 2020
@colemanw
Copy link
Member

Love the PR title!

@colemanw colemanw merged commit 7b88e99 into civicrm:master Jul 12, 2020
@demeritcowboy demeritcowboy deleted the comment-resultset branch July 13, 2020 01:02
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @colemanw