Sort permittedActivityTypes #17794
Merged
Sort permittedActivityTypes #17794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining whether to add a clause filtering activity types the permitted types are compared to all types. If all are permitted no clause is needed. However, without this sort it is incorrectly seeing them as not matching and adding extraneous joins
|
(Standard links)
|
|
This seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When determining whether to add a clause filtering activity types the permitted types
are compared to all types. If all are permitted no clause is needed.
Before
activity_type_id IN (1,3,,4) added, even when all activity type ids are in the IN
After
Clause not added if it includes all types
Technical Details
Without this sort it is incorrectly comparing the keys of the 2 arrays in addSelectWhere and concluding that they differ
Comments