dev/core#1868 - Regression - Description field is always blank on profiles admin page and slew of E_NOTICES

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1868

Before

Blank description field at Administer - Customize - Profiles.
Lots of E_NOTICES.

After

Good.

Technical Details

Recent cleanup to remove pre 4.4.7 upgrade code accidentally removed the description lookup. This puts it back.

Comments

Seems to only be in master.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Patch makes sense conceptually.

You could probably put description in the list of fields unconditionally and skip the checkIfFieldExists(). Per UFGroup.xml, the description was added in 4.4 - so anybody who meets the new "miniumum upgrade version" (4.4.7) should already have the field.

[demeritcowboy]

Thanks makes sense. I had just copied what was there before and didn't really think about it. Have updated.

[eileenmcnaughton]

@demeritcowboy does this only affect master? I feel like the commits were pretty recent so probably it does?

[demeritcowboy]

Yes only affects master.

[eileenmcnaughton]

@demeritcowboy and having processed @totten's comments above do you think this should be merged as is?

I read them as non-blocking but please consider this. So if you have done so I'm happy to merge

[demeritcowboy]

Yep I addressed @totten 's comments. In the first version I had put back the if checkiffieldexists that was there before. This version assumes the field is present since you can no longer upgrade from a version where it isn't present.

[eileenmcnaughton]

thanks @demeritcowboy

[demeritcowboy]

Thanks