dev/drupal#114 and dev/core#1647 - Remove resource url status check

[demeritcowboy]

Overview

This check is driving several people nuts.

It made sense at the time it was introduced - my understanding is it mimicked the small missing arrow in the menus, which was subtle and so it wasn't obvious there was a problem or what it was. But:

• The arrow it checks for is no longer used in the menus,
• The check is ALWAYS a false negative in drupal 8 (and I understand maybe wordpress too),
• It's a false negative if using a self-signed certificate,
• And the symptoms are no longer subtle so it doesn't require a check. Now if resources can't be loaded then typically your menus are completely messed up.

It could maybe be replaced with something else, but want to wait to see what happens with https://lab.civicrm.org/dev/core/-/issues/1647.

Before

False negatives.

After

Better

Technical Details

It assumes packages is under userFrameworkResourceUrl, but it no longer always is.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I see one +1 already - I think if this gets a handful more we can merge. The logic sounds good to me

[KarinG]

Ok there's the handful! +5 :-)

[MegaphoneJon]

I just +1'ed this, and I wrote the check. It seemed like a good idea at the time 🤷

[demeritcowboy]

Thanks everybody!