Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused functions in GenCode #17753

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

I can't see where these functions are used. Came up while reviewing a PR.

@civibot civibot bot added the master label Jul 4, 2020
@civibot
Copy link

civibot bot commented Jul 4, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I reached the same conclusion grepping. In addition I found this change makes this unused

CRM_Core_CodeGen_Util_File::digestAll

Removing functions used in the gencode process would have caused tests to fail - but test fail is unrelated.

@eileenmcnaughton eileenmcnaughton merged commit ffc370f into civicrm:master Jul 5, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks. Yes to digestAll() and hmm... looks like findCoreSourceDir() too!

@demeritcowboy demeritcowboy deleted the unused-gencode branch July 5, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants