Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in templates/CRM/Report/Form/Tabs/GroupBy.tpl #17747

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Jul 3, 2020

Overview

In Reports, under the Group By section, there is a typo in the HTML, without a visual impact, but rather odd.

I'm not too sure how to trigger the behaviour on a default report. I was fiddling with a custom report (https://lab.civicrm.org/extensions/membershipreport) when I noticed it, but it wasn't happening on dmaster with the Contribution Detail report, because for some reason gbElem is not true.

@civibot civibot bot added the master label Jul 3, 2020
@civibot
Copy link

civibot bot commented Jul 3, 2020

(Standard links)

@demeritcowboy
Copy link
Contributor

I think it's safe to remove. It looks like it used to be this and somebody just left too much in when removing it:

<td width="25%" {if $form.fields.$gbElem} onClick="selectGroupByFields('{$gbElem}');"{/if}>

@seamuslee001 seamuslee001 merged commit 474c2bd into civicrm:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants