Fix currency symbol for Total Amount on contribution page

[mattwire]

Overview

"Total Amount" shows default system currency symbol if contribution page is configured to use a different currency.

Setup a simple contribution page with a price set and a text amount/quantity field. Set the currency on the contribution page to something other than the CiviCRM default.

Before

After

Technical Details

The correct currency symbol is assigned to the form but not used because the currency is formatted by CRM.formatMoney.
We change that to only return a number and append the currency symbol we already have. Note there is currently no way to pass the currency into CRM.formatMoney via javascript.

Comments

@eileenmcnaughton As you've started working on brick money as a formatter in CiviCRM this could probably be resolved in a better way. This fixes the immediate problem and indicates where a better formatter could be introduced. But that's probably something to work on after this is fixed.
@jitendrapurohit Can you review?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[irenemeisel]

(CiviCRM Review Template DEL-1.2)

• General standards

  • Explain (r-explain)

    • PASS : The goal/problem/solution have been adequately explained in the PR.

  • User impact (r-user)

    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.

  • Run it (r-run)

    • PASS:
      I duplicated this problem on the master branch and the patch fixed it

• Developer standards
  * UNREVIEWED
  I don't feel qualified to assess the code

• Code quality (r-code)
  * UNREVIEWED

• Maintainability (r-maint)
  * UNREVIEWED

• Test results (r-test)

    * __PASS__: The test results are all-clear.
  

[seamuslee001]

Code quality looks ok here and it has been r-run merging

[eileenmcnaughton]

thanks for the review @irenemeisel

[mlutfy]

This code assumes that the currency formatting displays the currency before the amount, which only applies to English-speaking countries and some South American countries. Quebec, Europe, Russia and most of Asia place the currency after.