[REF] Cleanup function for retrieving contact types. #17676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This switches to using the apiv4 as part of trying to eliminate calls to executeQuery where the DAO is passed in
like
```
= CRM_Core_DAO::executeQuery(, [],
FALSE, 'CRM_Contact_DAO_ContactType'
);
```
Note that this file seems to be the only place this is done.
Also note that I added tests first & the changes to the test highlight what is changed in the PR in the output - namely
- stricter type casting (courtesy apiv4)
- same keys present for all types
|
Jenkins re test this please |
| * @throws \API_Exception | ||
| */ | ||
| protected static function getAllContactTypes() { | ||
| if (!Civi::cache('contactTypes')->has('all')) { |
There was a problem hiding this comment.
@eileenmcnaughton do we need to bust this cache whenever a contact type is enabled or disabled or deleted or does the system already do that sensibly?
There was a problem hiding this comment.
It's already doing Civi::cache('contactTypes')->clear();
|
This seems fine to me and unit tests should cover us here I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup intended to allow us to deprecate a couple of odd params in
CRM_Core_DAO::executeQuery- naming $abort = FALSE & $daoName.Before
Use of older methods
After
Retrieves using apiv4 - DB retrieves & caches once & filters as needed - should be so cheap as to not warrant caching the filtering
Technical Details
This switches to using the apiv4 as part of trying to eliminate calls to executeQuery where the DAO is passed in
like
Note that this file seems to be the only place this is done.
Also note that I added tests first & the changes to the test highlight what is changed in the PR in the output - namely
Comments