Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if id not passed into discard #17666

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/drupal/-/issues/123 - may not be related but this seems a good precaution

Before

Calling BAO_Group::discard with NULL looks like it might over-delete.

After

Calling BAO_Group::discard with NULL would throw an exception

Technical Details

I can't find any evidence this is happening but it seems like a sensible precaution

Comments

@civibot
Copy link

civibot bot commented Jun 20, 2020

(Standard links)

@civibot civibot bot added the master label Jun 20, 2020
@mlutfy mlutfy merged commit f12d958 into civicrm:master Jun 22, 2020
@eileenmcnaughton eileenmcnaughton deleted the entity_log branch June 25, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants