[dev/core#750] Don't check server variables if we're running in CLI #17636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This PR introduces skipping the server variable checks if we're running in a CLI environment, removing an error when running Drush commands against Drupal 8 and Drupal 9 based sites. Fix whitespace errors. Remove variable comment. Fix more whitespace!
|
@mikeyMJCO I tested this and running a straight drush updb still left me with which seems to come from https://github.com/civicrm/civicrm-core/blob/master/setup/plugins/checkRequirements/CheckDrushBaseUrl.civi-setup.php#L23 but otherwise this works |
|
@seamuslee001 'otherwise this works' -= "better in than out?" |
|
yes merging |
|
I'm on civicrm 5.30alpa and i still see this error on drupal 9 |
|
Same here: CiviCRM 5.33.2 / Drupal 9.1.2 |
|
This is a merged/closed PR - please open an issue on https://lab.civicrm.org if you're still seeing this issue which relates ONLY to warnings shown in CLI tools (e.g Drush). For any other issues you can open an issue on GitLab but it's not likely to be related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces skipping the server variable checks if we're running in a CLI environment, removing an error when running Drush commands against Drupal 8 and Drupal 9 based sites.
Before
What is the old user-interface or technical-contract (as appropriate)?
Drush commands error due to missing server variables, however we shouldn't actually check these variables when running from CLI environments as it's not reasonable to expect them to be set.
After
What changed? What is new old user-interface or technical-contract?
The server variables check is now only run for non-cli environments. The error no longer appears!