Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Remove instances where html is passed to crmMoney #17612

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 14, 2020

Overview

After grepping I'm pretty confident the other params are never passed so removed

Before

Invalid calls to crmSmarty on input html

The HTML is passed to the money-formatter, but the value isn't changed (because it's malformed input).

After

Calls removed, also unused params removed

The HTML is not passed to the money-formatter.

After grepping I'm pretty confident the other params are never passed so removed
@civibot
Copy link

civibot bot commented Jun 14, 2020

(Standard links)

@civibot civibot bot added the master label Jun 14, 2020
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this should be simple & simply later ones..

@seamuslee001
Copy link
Contributor

Changes work for me in local testing merging

@seamuslee001 seamuslee001 merged commit 8debf42 into civicrm:master Jun 19, 2020
@seamuslee001 seamuslee001 deleted the format branch June 19, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants