[NFC] Add assertions to existing test to lock in current behaviour #17605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per standard tdd refactoring I'm adding tests before I alter the code that is tested. Note that the code has quite a bit I think can go
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 14, 2020
Now we have test cover from civicrm#17605 and other recents we can consolidate this code & be comfortable the test cover will pick up issues.
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 14, 2020
Now we have test cover from civicrm#17605 and other recents we can consolidate this code & be comfortable the test cover will pick up issues.
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 14, 2020
Now we have test cover from civicrm#17605 and other recents we can consolidate this code & be comfortable the test cover will pick up issues.
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 15, 2020
Now we have test cover from civicrm#17605 and other recents we can consolidate this code & be comfortable the test cover will pick up issues.
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 15, 2020
Now we have test cover from civicrm#17605 and other recents we can consolidate this code & be comfortable the test cover will pick up issues.
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jun 15, 2020
Now we have test cover from civicrm#17605 and other recents we can consolidate this code & be comfortable the test cover will pick up issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per standard tdd refactoring I'm adding tests before I alter the code that is tested. Note that the code
has quite a bit I think can go
Before
Various parameters are not checked
After
Parameters checked
Technical Details
Note I removed 'source' => '' as it turns out not to be on the form
Comments