[REF] Fix some additional issues where curly braces were being used t… #17599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o access string or array offsets
|
(Standard links)
|
|
also this @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o access string or array offsets
Overview
This fixes another couple of issues with {} being used to access array/string offsets
Before
Code having issues on PHP7.4
After
Code works on PHP7.4
ping @eileenmcnaughton
Tests that demonstrate the issues https://test.civicrm.org/job/CiviCRM-Core-Edge/513/CIVIVER=master,label=test-3/testReport/(root)/api_v3_ACLPermissionTest/testContactGetNoResultsHook_with_data_set__0/ https://test.civicrm.org/job/CiviCRM-Core-Edge/513/CIVIVER=master,label=test-3/testReport/(root)/api_v3_CustomFieldTest/testCustomFieldCreateAllAvailableFormInputs/ and
CRM_Core_Page_HookTest