dev/financial#131 Give deprecation notice if the payment processor returns an error #17596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns an error This notice will show up on dev sites & should highlight the expectation that processors throw errors
|
(Standard links)
|
|
Merging as this seems sensible to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Payment Processors are expected to throw PaymentProcessorExceptions rather than return CRM_Core_Error objects - we have fixed all the core ones & some community ones (IATS) are fixed whereas others have not returned error objects for some time - this should flush out the others
Deprecation notices will be visible on sites that are in developer mode (which translates to the presence of .git or .svn) and have e-notice settings that surface Deprecated level bugs.
Also note that this will not affect process who implement doPayment (recommended)
Before
CRM_Core_Payment silently handles returned errors,
After
CRM_Core_Payment noisily handles returned errors.
Technical Details
Comments