core#1805: Autocomplete-select custom field is not searchable

[monishdeb]

Overview

Steps to replicate:

1. Create an 'Autocomplete Select' custom field for any component, say Contribution here
2. Update/add two or more records with these custom field options
3. Go to the desired search form, here 'Find Contribution'
4. Select two or more option and submit the criteria

Before

After

Technical Details

This patch introduces two improvement and the fix for the current issue, depends on it:

1. I have moved the CRM_Core_BAO_CustomValue::fixCustomFieldValue inside CRM_Contact_BAO_Query::convertFormValues(...) and its safe for two reason:

• This latter fn is been accessed by both API and Search Forms to format the parameters in query format. For customfields, when it is used in API parameter, its already in OK (Operator in Key) format thus the CRM_Core_BAO_CustomValue::fixCustomFieldValue fn bypass for value for formatting in here
• As you can see in the patch, fixCustomFieldValue fn is executed separately on all Search forms in order to format the customfield's value. The reason, why I have moved the fn and won't cause any unintended regression. In addition it gives more authority to CRM_Contact_BAO_Query::convertFormValues to now format the customfield filters too.

2. Added form validation to prevent entering comma value in custom field form.

Comments

ping @eileenmcnaughton @seamuslee001 @JoeMurray @lcdservices

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I think this looks OK if an r-run passes - one thing to check is that a smart group based on this reloads OK

[monishdeb]

Thanks for pointing that out. I will mention the test result shortly with smart group.

[seamuslee001]

This makes me wonder if we need to have a status check or something as well alerting if people have any already

[monishdeb]

For existing optionValue's value, with comma will won't work for 'Autocomplete Select' custom field as a filter, but doesn't affect another widget type (as a filter) like checkbox. But yeah it would be nice to inform user about this change, on status page, something like 'Use of "," is no longer supported in optionvalue for mult-select custom fields esp. for 'Autocomplete Select' widget'

[JoeMurray]

Let's remove webaccess as historical cruft and update this to 'test@example.com'

[monishdeb]

done

[monishdeb]

jenkins test this please

[lcdservices]

Tested and this works as expected.
Also tested and confirmed when creating a smart group based on the custom field's criteria.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

This was only pending r-run so MOP now @lcdservices has done so

[eileenmcnaughton]

unrelated fail