Remove unreachable lines #17563
Merged
Remove unreachable lines #17563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Jun 9, 2020
| @@ -1852,12 +1852,6 @@ public static function processMembership($contactID, $membershipTypeID, $is_test | |||
| if (!empty($membershipSource)) { | |||
| $currentMembership['source'] = $membershipSource; | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
I can demonstrate on the other function with a test that we don't need to pass this in if unchanged
|
@eileenmcnaughton looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up from
#17556
Before
Unreachable lines
After
Gone
Technical Details
@mattwire agreed a follow up is useful. I've added a couple of related changes I identified in the shorter function
Comments