Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ref] Unit test attempt to create reported bugs , minor cleanup #17560

Merged
merged 1 commit into from
Jul 20, 2020
Merged

[Ref] Unit test attempt to create reported bugs , minor cleanup #17560

merged 1 commit into from
Jul 20, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 9, 2020 •
edited
Loading

Overview

This lays the ground work to test a couple of reported bugs. Minor cleanup of code

Before

Less test cover, less readability

After

More

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 9, 2020

(Standard links)

@civibot civibot bot added the master label Jun 9, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton mentioned this pull request Jul 14, 2020
Closed
@eileenmcnaughton eileenmcnaughton changed the title [Ref] Unit test attempt to create reported bugs , minor refactor [Ref] Unit test attempt to create reported bugs , minor cleanup Jul 14, 2020
@eileenmcnaughton
[Ref] Unit test attempt to create reported bugs , minor refactor
24a6783 
This lays the ground work to test a couple of reported bugs. Minor cleanup of code
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 can you merge this - it's really just a test & a caching fix

@seamuslee001
Copy link
Contributor

yeh this seems fine

@seamuslee001 seamuslee001 merged commit d337c22 into civicrm:master Jul 20, 2020
@seamuslee001 seamuslee001 deleted the import branch July 20, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001