Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1801 Fix hardcoded activity priority by label #17557

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

marcineqpol
Copy link
Contributor

@marcineqpol marcineqpol commented Jun 8, 2020

Overview

Fix issue with set default priority in non-english installation. https://lab.civicrm.org/dev/core/-/issues/1801

Before

Default priority must have "Normal" in label. When change label of "Normal" priority - field as empty.

After

Default priority is set to "Normal" value, regardless of the label name.

Technical Details

Comments

Thanks for @eileenmcnaughton for this code. I am sending PR so that the change can occur in CiviCRM. Thanks a lot.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Jun 8, 2020

(Standard links)

@civibot civibot bot added the master label Jun 8, 2020
@eileenmcnaughton
Copy link
Contributor

add to whitelist

@eileenmcnaughton
Copy link
Contributor

Thanks @marcineqpol for getting this submitted. Good to get it wrapped up to save others from hitting it.

I think this is good to merge once it passes tests as you have acted in the role of tester too here.

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Test fail unrelated merging

@seamuslee001 seamuslee001 merged commit 867ca33 into civicrm:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants