Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] Remove some instances of fatal in BAO classes #17536

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Ref] Remove some instances of fatal in BAO classes

Before

  CRM_Core_Error::fatal(ts('No batches were selected.'));

After

  throw new CRM_Core_Exception(ts('No export format selected.'));

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 7, 2020

(Standard links)

@civibot civibot bot added the master label Jun 7, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit aa07663 into civicrm:master Jun 7, 2020
@seamuslee001 seamuslee001 deleted the fatal3 branch June 7, 2020 10:50
@seamuslee001 seamuslee001 restored the fatal3 branch June 7, 2020 10:50
@seamuslee001 seamuslee001 deleted the fatal3 branch June 7, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants