Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Replace some instances of fatal with thrown exceptions. #17533

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This is ongoing cleanup to consistently throw exceptions.

Before

CRM_Core_Error::fatal();

After

throw new CRM_Core_Exception(' no contact found');

Technical Details

The only thing notable is in the OG class where
it turned out the exception was thrown if a never-passed-in-parameter was passed in, so I removed the
construct

Comments

@civibot civibot bot added the master label Jun 7, 2020
@civibot
Copy link

civibot bot commented Jun 7, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

@eileenmcnaughton test fail relates

This is ongoing cleanup to consisently throw execptions. The only thing notable is in the OG class where
it turned out the exception was thrown if a never-passed-in-parameter was passed in, so I removed the
construct
@seamuslee001
Copy link
Contributor

test failure unrelated

@seamuslee001 seamuslee001 merged commit 1eed55e into civicrm:master Jun 8, 2020
@seamuslee001 seamuslee001 deleted the fatal branch June 8, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants