Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to multi-valued custom groups and display on contact tab #17531

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 7, 2020

Overview

Allows selecting an icon for custom tabs on the contact summary screen.

Before

Custom tabs were always "fa-gear"

After

Now you can pick an icon for custom fields displaying as "Tab" or "Tab with Table" on the contact summary screen.

@civibot
Copy link

civibot bot commented Jun 7, 2020

(Standard links)

@civibot civibot bot added the master label Jun 7, 2020
@MegaphoneJon
Copy link
Contributor

This is already possible with Contact Summary Layout, is it not?

@colemanw
Copy link
Member Author

colemanw commented Jun 7, 2020

@MegaphoneJon yes that extension can edit icons on the tabs.

However, the reason I want to add this to core is also for the benefit of the new Search Builder UI.

I just did another PR to add translated titles and icons to core entities. These get exposed, via APIv4, to the Search UI.

Multi-record custom field sets are also treated as "Entities" by APIv4 and the search UI, so this gets them on par with those features of core entities.

@colemanw
Copy link
Member Author

colemanw commented Jun 8, 2020

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants