Payment instrument ID is not required at processorform level

[mattwire]

Overview

The paymentInstrumentID parameter is not required in CRM_Core_Payment_Form::buildPaymentForm() but if it is not set it throws PHP warnings.

Found during development of #17508

Before

PHP warnings if not set.

After

No warnings.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

I think we've been working on the assumption it IS required at the payment processor level.

Can we lock in that it IS required? The architectural assumption is that there is a processor per payment method, - so IATS direct debit is a different processor than IATS credit card

[mattwire]

@eileenmcnaughton Can you take another look - I think you've misunderstood this. The default paymentInstrumentID comes from the paymentprocessor object (the second param to buildPaymentForm) but it can be overridden by setting the last parameter (which defaults to NULL if not set).

The change in this PR allows us to NOT set the override on the form. I found this as part of the eventcart development but I hope to follow up with a fix for https://lab.civicrm.org/extensions/smartdebit/-/issues/2 which should allow us to align with your comments.

[eileenmcnaughton]

Yes! You are right!