Fix probably-unused core payment processors to throw extensions #17502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Jun 5, 2020
|
|
||
| /* Check for application errors */ | ||
|
|
||
| $result = self::checkResult($pjpgResponse); |
There was a problem hiding this comment.
This function does nothing
|
Jenkins re test this please |
These 2 processors are probably entirely unused and are not enabled on new installs. However, as they are still in core, and removing them will take a plan + time, we should have them model 'good behaviour' - ie throwing exceptions rather than returning errors
|
changes look fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make FirstData and Payjunction comply with our error handling expectations
Before
After
throw new PaymentProcessorException($message, 9003);
Technical Details
These 2 processors are probably entirely unused and are not enabled on new installs. However, as they are still in core,
and removing them will take a plan + time, we should have them model 'good behaviour' - ie throwing exceptions
rather than returning errors
Comments