dev/core#1776 Ensure that all fee financial item transaction date is … #17389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…set to the recieve date of the contribution
seamuslee001
force-pushed
the
dev_core_1776
branch
from
db4dfb2
to
83a3043
Compare
|
Jenkins re test this please |
|
This makes sense - my only worry is what would happen in trxn_date is not set - but this function is pretty solidly tested and that should have shown up as an e-notice if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set to the recieve date of the contribution
Overview
This ensures that for Financial items of bank fees the transaction_date is set to the receive date of the contribution
Before
transaction date set to today
After
Transaction date set to the date received
ping @JoeMurray @eileenmcnaughton @jitendrapurohit @monishdeb