Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HEAD requests to generate a form key #17321

Merged
merged 1 commit into from
Jun 12, 2020
+14 −2
Merged

Allow HEAD requests to generate a form key #17321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions CRM/Core/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,11 +284,23 @@ public function key($name, $addSequence = FALSE, $ignoreKey = FALSE) {
return NULL;
}

$key = $_REQUEST['qfKey'] ?? NULL;
if (!$key && $_SERVER['REQUEST_METHOD'] === 'GET') {
// We need a form key. Check _POST first, then _GET.
// @todo Note: we currently have to check $_REQUEST, too, since that
// is currently overwritten by civicrm_api3_contribution_page_validate.
// It's bad form to use $_REQUEST because it's ambiguous; and it's bad form
// to change superglobals anyway. If PR
// https://github.com/civicrm/civicrm-core/pull/17324
// and/or related get merged, then we should remove the REQUEST reference here.
$key = $_POST['qfKey'] ?? $_GET['qfKey'] ?? $_REQUEST['qfKey'] ?? NULL;
if (!$key && in_array($_SERVER['REQUEST_METHOD'], ['GET', 'HEAD'])) {
// Generate a key if this is an initial request without one.
// We allow HEAD here because it is used by bots to validate URLs, so if
// we issue a 500 server error to them they may think the site is broken.
$key = CRM_Core_Key::get($name, $addSequence);
}
else {
// Other requests that usually change data (POST, but feasibly DELETE,
// PUT, PATCH...) always require a valid key.
$key = CRM_Core_Key::validate($key, $name, $addSequence);
}

Expand Down