Remove slow join from activity search #17250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Test fails look related @eileenmcnaughton |
|
test this please |
|
@jaapjansma I see you are testing - do you have any sites with ACLs & largish datasets. I haven't cleaned up the tests on this because I was hoping @andrew-cormick-dockery would get a chance to check this for performance. It performs better for contacts not subject to ACLs |
|
Jenkins re test this please |
|
I did some testing of this on the AUG test infrastructure and didn't notice any significant deterioration in performance. @eileenmcnaughton are you able to fix the test failures |
eileenmcnaughton
force-pushed
the
act_search
branch
from
af0e016
to
652a5ab
Compare
|
Jenkins re test this please |
eileenmcnaughton
force-pushed
the
act_search
branch
from
652a5ab
to
575821f
Compare
This removes the unindexed join from activity search. The join is used to apply component permission filtering and to retrieve the activity_type - however, this latter is still rendered by the pseudoconstant handling
eileenmcnaughton
force-pushed
the
act_search
branch
from
575821f
to
d1d108e
Compare
|
Test fail unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes the unindexed join from activity search. The join is used to apply component
permission filtering and to retrieve the activity_type - however, this latter is still rendered
by the pseudoconstant handling
Before
Slow join
After
Faster
Technical Details
Comments
Will need some performance testing on a site that uses ACLs once we have seen if tests fail.
On sites without ACLs it should be clearly faster.