APIv4 - Deprecate old way of retrieving activityType/optionValue ids

[colemanw]

Overview

This deprecates some old stuff in APIv4 which was half-baked and maybe not even tested. The new pseudoconstant matching takes its place.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw jenkins isn't feeling it

[colemanw]

@eileenmcnaughton fixed.