[REF] stop overriding postProcess function in activity report detail #17194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton see style checker complaint |
The function is the same as master except one extra thing that can be done in the function intended for report-specific preProcess overrides
eileenmcnaughton
force-pushed
the
act_report
branch
from
fe77e6f
to
c6f4d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor cleanup on report
Before
Report overrrides parent with copy & paste code
After
Parent function is called, the one additional action is moved to the more appropriate beginPostProcessCommon
Technical Details
The function is the same as master except one extra thing that can be done in the function intended for
report-specific beginPostProcess overrides
Comments