Remove unused parameter, immediately overwritten parameter #17131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -132,15 +143,14 @@ public function buildQuickForm() { | |||
| // get the profile information | |||
| if ($this->_batchInfo['type_id'] == $batchTypes['Contribution']) { | |||
| CRM_Utils_System::setTitle(ts('Batch Data Entry for Contributions')); | |||
| $customFields = CRM_Core_BAO_CustomField::getFields('Contribution'); | |||
There was a problem hiding this comment.
FWIW, to my eye, the handling of $customFields in processMembership() looks fairly similar (i.e. no obvious/meaningful reads, only obvious writes). Not saying that needs to be addressed at the same time - but just in case you're interested.
Maybe after the r-test build finishes, then we just to do 5-min r-run on the autobuild site to confirm that the custom-fields still render+save on the batch-entry screen.
| } | ||
| elseif ($this->_batchInfo['type_id'] == $batchTypes['Membership']) { | ||
| CRM_Utils_System::setTitle(ts('Batch Data Entry for Memberships')); | ||
| } | ||
| elseif ($this->_batchInfo['type_id'] == $batchTypes['Pledge Payment']) { | ||
| CRM_Utils_System::setTitle(ts('Batch Data Entry for Pledge Payments')); | ||
| } | ||
| $this->_fields = []; |
There was a problem hiding this comment.
see next line...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
Var defined, not used
After
poof
Technical Details
Comments