Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Remove all the places where tests unnecessarily pass to Membership::create #17088

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

The param is deprecated - no reasonn to pass in the tests

Before

CRM_Member_BAO_Membership::create($params, $ids);

After

CRM_Member_BAO_Membership::create($params);

Technical Details

As long as tests still pass this has no further impacts

Comments

…hip::create

The param is deprecated - no reasonn to pass in the tests
@civibot
Copy link

civibot bot commented Apr 16, 2020

(Standard links)

@civibot civibot bot added the master label Apr 16, 2020
@seamuslee001
Copy link
Contributor

Change looks good to me merging

@seamuslee001 seamuslee001 merged commit 65c0141 into civicrm:master Apr 17, 2020
@seamuslee001 seamuslee001 deleted the ids2 branch April 17, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants