Don't pass empty ids parameter, fix fatal

[eileenmcnaughton]

Overview

$ids is an optional parameter in Membership::create - we should not pass it if it has no meaning

Also -replace fatal with an exception

Before

        $ids = [];
        CRM_Member_BAO_Membership::create($params, $ids);

After

 CRM_Member_BAO_Membership::create($params);

Technical Details

There is no other reference to $ids in the changed function

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton looks good to me, ready to merge.

[eileenmcnaughton]

Thanks @yashodha @mattwire