[REF] Update Contact email form to use the trait for EmailCommon functions

[eileenmcnaughton]

Overview

[REF] Update Contact email form to use the trait for EmailCommon functions

Before

CRM_Contact_Form_Task_Email does not share trait preProcess code

After

Code from trait used by CRM_Contact_Form_Task_Email where they overlap

Specifically the goal is to move interaction with CRM_Contact_Form_Task_EmailCommon to the trait class (and then to copy it directly onto the trait class & deprecate CRM_Contact_Form_Task_EmailCommon to the extent possible with an aim to eventual removal

Technical Details

• I had to rename the existing preProcess function so it could be called from both
• I dug into $this->assign('isAdmin', 1); and it affects the help message. It seems to be only on the contact form task by omission rather than design
• the reason CRM_Contact_Form_Task_Email only calls it's parent sometimes is obscure but this maintains tha.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Refactor looks good.