[REF] Use bool instead of boolean #17013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Apr 7, 2020
CRM/Report/Form/Grant/Statistics.php
Outdated
| @@ -487,7 +487,7 @@ public function alterDisplay(&$rows) { | |||
| "({$values['percentage']}%)"; | |||
| } | |||
| $totalAmt = implode(', ', $totalAmount); | |||
| $count = (boolean) CRM_Utils_Array::value('count', $values, 0) ? $values['count'] . " ({$values['percentage']}%)" : ''; | |||
| $count = (bool) CRM_Utils_Array::value('count', $values, 0) ? $values['count'] . " ({$values['percentage']}%)" : ''; | |||
There was a problem hiding this comment.
Wow this line gets a 🏆 for unnecessary complexity. I had to read it 3 times before realizing that the (bool) cast isn't affecting the assignment and $count is actually being assigned a string value here, not a bool.
How about:
Suggested change
| $count = (bool) CRM_Utils_Array::value('count', $values, 0) ? $values['count'] . " ({$values['percentage']}%)" : ''; | |
| $count = !empty($values['count']) ? $values['count'] . " ({$values['percentage']}%)" : ''; |
There was a problem hiding this comment.
Right. I read it another 3 times and then rearranged it slightly to reverse the polarity (which always works) and remove the string concatenation.
demeritcowboy
changed the title
|
Much better 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bool instead of boolean as per standard.
Simplify complicated expression.