Fixed fatal error for class not found when managed hook is invoked du…

[pradpnayak]

…ring upgrade

Overview

For https://civicrm.stackexchange.com/questions/35285/is-this-wordpress-critical-error-after-upgrade-to-5-24-1-serious

Regression from 5.22.1 (#16521)

Before

Failed to load class after upgrade

After

Upgraded Civi without error

Technical Details

Since hook_civicrm_config() is not invoked while upgrade the get_include_path() doesn't have path for extension which may cause fatal error when managed hook is invoked.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pradpnayak]

should this be against 5.24 branch?

[seamuslee001]

I would appreciate @totten 's thoughts on this

[pradpnayak]

just for information, this issue occurs only when upgrade done through UI but cannot be reproduce using CLI method.

[kcristiano]

@pradpnayak Is there an extension that I can install to reproduce? I do 99% of my upgrades via cli so I have missed these. I just upgraded 'clean' installs via the UI without incident, so this must be extension specific.

[pradpnayak]

Civirules may be good one.

[kcristiano]

Thanks That did it.

I was able to reproduce the error.

I did an r-run on 5.24 and 5.25 RC with the patch applied and this fixes the issue.

I think we should have this against the RC and I am inclined to add to 5.24 as well. @totten what do you think?

[colemanw]

I agree. I've rebased this into the 5.25 branch.

[seamuslee001]

Jenkins re test this please