dev/core#1673 Ensure that SQL statements are not duplicated in the de…

[seamuslee001]

…veloper tab of reports

Overview

This ensures that the formatted SQL only contains unique SQL statements rather than duplicated ones.

Before

Load up the contribution summary report and check the developer tab and note that one of the 2 SQLs is printed twice on the developer tab

After

Correct number of SQL statements are rendered

Technical Details

The problem is that you have 2 form variables

$this->sqlArray and $this->sqlFormattedArray and the issue is that when it is first called both are empty. So the buildQuery SQL is added to both correctly. The 2nd time it gets called from within the statistics function in the contribuiton summary report. The sqlArray already has the build report query in it so it gets looped in again when we do the foreach loop so gets re-formated again and re-added to the sqlformattedArray variable. This fixes it by resetting the sqlFormattedArray variable before the foreach

ping @eileenmcnaughton @monishdeb

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

OK - I'm happy to go with this based on your analysis - I had noticed the double ups & the impact of a mistake in this area is minimal