dev/user-interface#14 Fix membership_status_id url handling (recent regression). #16933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a recent regression whereby the links to membership search from the membership dashboard don't filter correctly on export
Before
On membership dashboard click through to a group of members - they should be filtered by membership type & status in the url
In actions dropdown click 'Export members'
Export list - and see that other statuses are included
After
Correct list of statuses & types exported
Technical Details
The right fix here is to fix the xml to the field setting it to export & adding a uniquename.
However, with our search focus moving on to the new search functionality in the pipeline & us having had
a hiatus on dealing with search code I think this more conservative change + a rc focus makes sense
at the moment
Comments
https://lab.civicrm.org/dev/user-interface/-/issues/14