Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/user-interface#14 Fix membership_status_id url handling (recent regression). #16933

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 31, 2020

Overview

Fixes a recent regression whereby the links to membership search from the membership dashboard don't filter correctly on export

Before

On membership dashboard click through to a group of members - they should be filtered by membership type & status in the url
In actions dropdown click 'Export members'
Export list - and see that other statuses are included

After

Correct list of statuses & types exported

Technical Details

The right fix here is to fix the xml to the field setting it to export & adding a uniquename.

However, with our search focus moving on to the new search functionality in the pipeline & us having had
a hiatus on dealing with search code I think this more conservative change + a rc focus makes sense
at the moment

Comments

https://lab.civicrm.org/dev/user-interface/-/issues/14

…egression).

The right fix here is to fix the xml to the  field setting it to export & adding a uniquename.

However, with our search focus moving on to the new search functionality in the pipeline & us having had
a hiatus on dealing with  search  code I think this more conservative change + a rc focus makes sense
at the  moment
@civibot
Copy link

civibot bot commented Mar 31, 2020

(Standard links)

@civibot civibot bot added the 5.24 label Mar 31, 2020
@jitendrapurohit
Copy link
Contributor

Just tested this and confirmed the default selection of status and types works fine. The export file correctly includes all the members filtered by these input fields

Noting that the dashboard also contains a link which redirects to the search form with owner=1 URL filter expecting only primary members to show.

Screenshot 2020-03-31 at 5 05 57 PM

The result is shown correctly but, in this case, the export file includes the non-primary members too.

As this is for rc, would be ok to handle that in a follow up PR and merge this change 👍

@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

I'm going to merge this based on @jitendrapurohit 's testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants