Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Minor simplification - do not use variable variables #16927

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This is a minor readabilty improvement because it's awful. Much more could be done....

Before

Use of variable variables

After

Just define the darn thang

Technical Details

Comments

This is a minor readabilty improvement because it's awful. Much more could be done....
@civibot
Copy link

civibot bot commented Mar 31, 2020

(Standard links)

@civibot civibot bot added the master label Mar 31, 2020
@colemanw colemanw merged commit ff3b82e into civicrm:master Mar 31, 2020
@colemanw colemanw deleted the campaign branch March 31, 2020 14:09
@colemanw
Copy link
Member

Ironically, the "fancy/abstract" way they were doing it before actually used more code than just defining the variables directly.

@eileenmcnaughton
Copy link
Contributor Author

yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants