APIv4 - Only adjust domain_id if required #16917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Alternative to #16911
In 60142ef this field was set to be handled automatically across all entities, however this caused problems with entities like optionValue where it can be NULL. This lifts the default if the field is not required.
Before
In all api4 entities,
domain_id
field not required and given default value.After
In all api4 entities,
domain_id
field not required and given default value only if required in the database.