Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Only adjust domain_id if required #16917

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

colemanw
Copy link
Member

Overview

Alternative to #16911
In 60142ef this field was set to be handled automatically across all entities, however this caused problems with entities like optionValue where it can be NULL. This lifts the default if the field is not required.

Before

In all api4 entities, domain_id field not required and given default value.

After

In all api4 entities, domain_id field not required and given default value only if required in the database.

@civibot
Copy link

civibot bot commented Mar 27, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Looks good to me merging

@seamuslee001 seamuslee001 merged commit 0597447 into civicrm:master Mar 27, 2020
@colemanw colemanw deleted the domainId2 branch March 28, 2020 00:18
@eileenmcnaughton
Copy link
Contributor

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants