Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #16914

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Remove unused code #16914

merged 1 commit into from
Mar 27, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove code that appears unnreachable

Before

Unreachable code present

After

poof, more cleanup can follow

Technical Details

If seems to me that 1) if this IF is true then there will be a bounce & it will not proceed and
2 if it IS true emailAddress does not seem to be added as a field to the form anywhere I can see.

Note that $bounce is only false for pdfs I believe

Comments

This appears to give some clues - I believe that @mattwire & maybe @seamuslee001 did work that made this obsolete

@demeritcowboy you are good at sleuthing on things like this

If seems to me that 1) if this IF is true then there will be a bounce & it will not proceed annd
2 if it IS true emailAddress does not seem to be applied anywhere
@civibot
Copy link

civibot bot commented Mar 27, 2020

(Standard links)

@civibot civibot bot added the master label Mar 27, 2020
@yashodha
Copy link
Contributor

test this please

@colemanw colemanw merged commit 41e1561 into civicrm:master Mar 27, 2020
@colemanw colemanw deleted the act2 branch March 27, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants