[NFC] Use strict comparison where possible #16896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
colemanw
reviewed
Mar 25, 2020
CRM/Activity/Form/Activity.php
Outdated
| @@ -823,7 +823,7 @@ public function buildQuickForm() { | |||
| */ | |||
| public static function formRule($fields, $files, $self) { | |||
| // skip form rule if deleting | |||
| if (CRM_Utils_Array::value('_qf_Activity_next_', $fields) == 'Delete') { | |||
| if ($fields['_qf_Activity_next_'] ?? NULL === 'Delete') { | |||
There was a problem hiding this comment.
This seems a little ambiguous about which operator goes first (?? or ===)
Suggested change
| if ($fields['_qf_Activity_next_'] ?? NULL === 'Delete') { | |
| if (($fields['_qf_Activity_next_'] ?? NULL) === 'Delete') { |
There was a problem hiding this comment.
lol - I was going the brackets but thought you have been removing them from lots of places where I wanted them
colemanw
reviewed
Mar 25, 2020
CRM/Activity/Form/Activity.php
Outdated
| @@ -958,7 +958,7 @@ public function postProcess($params = NULL) { | |||
| $this->_activityId | |||
| ); | |||
|
|
|||
| $params['is_multi_activity'] = CRM_Utils_Array::value('separation', $params) == 'separate'; | |||
| $params['is_multi_activity'] = $params['separation'] ?? NULL === 'separate'; | |||
There was a problem hiding this comment.
Suggested change
| $params['is_multi_activity'] = $params['separation'] ?? NULL === 'separate'; | |
| $params['is_multi_activity'] = ($params['separation'] ?? NULL) === 'separate'; |
There was a problem hiding this comment.
@colemanw fixed
Also fixes a couple of comments & uses of Array::value
|
Unrelated fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code standards cleanup
Before
Non-strict comparison used when comparing against strings
After
Strict comparison used
Technical Details
Also fixes a couple of comments & uses of Array::value
Comments
Strict comparison should always be used where possible