Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Add in unit test to ensure that APIv4 Doesn't accept an invalid… #16893

Merged
merged 1 commit into from
Mar 28, 2020
Merged

[NFC] Add in unit test to ensure that APIv4 Doesn't accept an invalid… #16893

merged 1 commit into from
Mar 28, 2020

Conversation

seamuslee001
Copy link
Contributor

… sort

Overview

This just adds a little defence for us proving that APIv4 doesn't at the moment accept an invalid sort parameter

Before

No Test

After

Test

ping @eileenmcnaughton @colemanw

@civibot
Copy link

civibot bot commented Mar 25, 2020

(Standard links)

@civibot civibot bot added the master label Mar 25, 2020
@seamuslee001
Copy link
Contributor Author

Jenkins retest this please

@eileenmcnaughton
Copy link
Contributor

it fails...

@seamuslee001
Copy link
Contributor Author

Should pass now

@colemanw colemanw merged commit 28f8e24 into civicrm:master Mar 28, 2020
@seamuslee001 seamuslee001 deleted the nfc_sort_api4_test branch March 28, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @eileenmcnaughton @colemanw