Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC/TEST] Resurrect unfinished test for getRelatedCases() #16885

Merged
merged 1 commit into from
Apr 1, 2020
Merged

[NFC/TEST] Resurrect unfinished test for getRelatedCases() #16885

merged 1 commit into from
Apr 1, 2020

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Mar 24, 2020 •
edited
Loading

Overview

This resurrects a 6 year old unfinished test because tests are cool, and also this test counts as a test for another PR which I'll post in a few seconds. It has nothing to do with this, but writing a test for that other PR has little value and would only fail on windows, so here is a test in lieu.

Also note that in endPostProcess() the ampersands can go because:

  • $form is never used
  • $params and $activity are never altered

@civibot
Copy link

civibot bot commented Mar 24, 2020

(Standard links)

@civibot civibot bot added the master label Mar 24, 2020
@demeritcowboy demeritcowboy mentioned this pull request Mar 24, 2020
Merged
@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

3 similar comments
@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

I've been hitting the same errors on a different PR

@eileenmcnaughton
Copy link
Contributor

I double checked the & removals & they all made sense

@eileenmcnaughton eileenmcnaughton merged commit 5a68129 into civicrm:master Apr 1, 2020
@demeritcowboy demeritcowboy deleted the test-getrelatedcases branch April 1, 2020 11:31
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @eileenmcnaughton