CRM/Contribute - Cleanup boolean expressions #16853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -1683,7 +1683,7 @@ protected function submit($submittedValues, $action, $pledgePaymentID) { | |||
| $action, | |||
| $pledgePaymentID, | |||
| $contribution->id, | |||
| (CRM_Utils_Array::value('option_type', $formValues) == 2) ? TRUE : FALSE, | |||
| ($formValues['option_type'] ?? 0) == 2, | |||
There was a problem hiding this comment.
This is the only one I'm not 100% sure about @eileenmcnaughton thoughts?
There was a problem hiding this comment.
It's the same logic in both expressions.
There was a problem hiding this comment.
Yes - it first resolved $formValues['option_type'] to it's value OR 0 and then compares with 2
There was a problem hiding this comment.
Guess it just seemed odd to me resolving to 0 when CRM_Utils_Array::value would have resolved to NULL but i guess for this purpose they are interchangeable values
There was a problem hiding this comment.
Yep - probably NULL would have been more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out from #16814.