Fix checking permissions in api3 profile get

[colemanw]

Overview

Fixes an apparent bug in api3 code where a boolean value needs to be inverted.

Technical Details

This is confusing so I'm gonna break it down here as much for myself as anyone reading this:

• civicrm_api3_profile_get takes a param called check_permissions.
  If true, permissions will be checked.
• CRM_Core_BAO_UFGroup::getFields takes a param called $skipPermission.
  If true, permissions will not be checked.
• The expression being passed into $skipPermission was empty($params['check_permissions']) ? FALSE : TRUE.
  That's a confusing way of saying a = a; the value stays the same.
• The problem is that the two functions expect their respective permission params to have opposite meanings, so in passing this param through from one function to the other, it needs to be inverted.

Comments

Whew! Brain hurts.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton I came across this randomly while fixing up bool expressions. Haven't tried running it and I doubt there's any test coverage.

retest this please

[eileenmcnaughton]

I agree!