dev/core#1663 - Fix warning on relationship form #16845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
yashodha
reviewed
Mar 19, 2020
| @@ -413,6 +413,9 @@ public function &add( | |||
| } | |||
| } | |||
| } | |||
| $optionContext = $extra['option_context'] ?? NULL; | |||
| unset($extra['option_context']); | |||
There was a problem hiding this comment.
@jitendrapurohit why are we unsetting $extra['option_context'] ?
There was a problem hiding this comment.
@yashodha option_context is in array format which is causing all the problems here. The main aim of this code seems to assign data-option-edit-context in the json format. This is done in the later part of the code. This PR avoids $element to have an unnecessary array attribute option_context which leads to the warning message on the relationship form.
|
@jitendrapurohit merging this PR |
jitendrapurohit
pushed a commit
to jitendrapurohit/civicrm-core
that referenced
this pull request
Apr 1, 2020
eileenmcnaughton
added a commit
that referenced
this pull request
Apr 1, 2020
Follow up PR for #16845 - Fix form error when variable is NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PHP warning display on add relationship form.
Before
To replicate - simply open a relationship form on a new window.
After
No warnings displayed.
Technical Details
Seems
option_contextwas added in https://github.com/civicrm/civicrm-core/pull/11853/files#diff-f9397c2b103c68ffb588679b5d4784a2. As we're only interested in adding the json string to it later in the code, this PR change avoids the array value to be added while creating the element.I'm not sure why we can't simply add
data-option-edit-contextjson attribute in the relationship form itself? thoughts @mickadoo @colemanw ?Comments
Gitlab - https://lab.civicrm.org/dev/core/issues/1663