Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CustomDataView.tpl plain empty memo field. #16839

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Mar 18, 2020

Overview

To reproduce:

  • Create a new Custom Field Group: for Contacts, repeatable, in tab form.
  • Create 3 fields: a normal text field, a 'note' with TextArea (not wysiwyg), and another text field.
  • Then go to a Contact record, and fill in a new instance of that group, but leave the fields empty.
  • Then go back to the Contact record, and click 'view' on that entity.

Result: two fields appear to be on the same line.

custom-fields

Before

Two labels on the same line.

After

Each (empty) field on its own line:

Capture d’écran de 2020-03-18 15-17-44

Technical Details

Not very elegant fix, but it's what the rest of the template does.

@civibot civibot bot added the master label Mar 18, 2020
@civibot
Copy link

civibot bot commented Mar 18, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

This looks fine to me merging

@seamuslee001 seamuslee001 merged commit c9542f8 into civicrm:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants