Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] cleanups on array operator #16821

Merged
merged 2 commits into from
Mar 17, 2020
Merged

[REF] cleanups on array operator #16821

merged 2 commits into from
Mar 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 17, 2020 •
edited
Loading

Partial of #16802 and #16820 as relate to the test folder - this is a reviewer's commit but I have not individually examined these as they are in the test folder & test cover will handle

@eileenmcnaughton
[REF] Replace CRM_Utils_Array::value with ?? in variable assignments
849ac82 
Partial of  civicrm#16768 - only contains test lines which I don't think need individual review
@eileenmcnaughton
[REF] Replace coalesce pattern with coalesce operator
511e9a2 
This replaces the innstances in the test folder.
@civibot
Copy link

civibot bot commented Mar 17, 2020

(Standard links)

@civibot civibot bot added the master label Mar 17, 2020
@eileenmcnaughton eileenmcnaughton changed the title Array3 [REF] cleanups on array operator Mar 17, 2020
@eileenmcnaughton eileenmcnaughton merged commit 2c035b1 into civicrm:master Mar 17, 2020
@eileenmcnaughton eileenmcnaughton deleted the array3 branch March 17, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eileenmcnaughton